melonDS
melonDS copied to clipboard
CI: Simplify Windows build workflow
- Use pacboy to download dependencies instead of a separate step.
- Use ninja instead of make because ninja is faster and native in msys2.
- Use cmake options instead of changing working directory every steps.
Look good to me.
Do you have a link to where these extra properties you are using are documented? I had no idea about them.
msys2's docs: https://www.msys2.org/docs/ci/ GitHub Marketplace docs: https://github.com/marketplace/actions/setup-msys2 msys2-setup repo: https://github.com/msys2/setup-msys2
This PR looks good - it makes the workflow file simpler as well.
Though, with Ninja is there supposed to be no colour in the output?
with Ninja is there supposed to be no colour in the output?
Yes. There are some hacks https://medium.com/@alasher/colored-c-compiler-output-with-ninja-clang-gcc-10bfe7f2b949. But it is not msys2 specific.