melonDS icon indicating copy to clipboard operation
melonDS copied to clipboard

Create ROMManager class to manage ROM/Save Data/Cheat File resources in Frontend.

Open dalchen opened this issue 4 years ago • 2 comments

This patch aims to create a class that manages the resources used for files in the Frontend namespace. Original functionality of all the functions moved into this class is kept. Resources are managed by the Meyers Singleton ROMManager, and members are managed via RAII.

dalchen avatar Jun 12 '21 03:06 dalchen

Reordered method definitions around for a cleaner diff.

Please let me know if this patch is reasonable! I will totally understand if you don't want to merge this since this patch has quite a few (unwarranted since things were working properly) changes.

dalchen avatar Jun 12 '21 03:06 dalchen

sorry, I don't really see the point of this. It doesn't seem to be useful to apply OOP in this case, especially since the singleton then destroys all the potential benefits of it again.

RSDuck avatar Jun 12 '21 12:06 RSDuck