melonDS icon indicating copy to clipboard operation
melonDS copied to clipboard

Added 'About' menu item w/ scmrev information

Open dinnme opened this issue 4 years ago • 3 comments

Allows the user to know on which revision they're on, alongside some useful links. [DO NOT MERGE]

  • Added an 'About' section (Located in the 'Help' menubar item or in the 'melonDS' menubar item on macOS)
  • Added a way to get the current git revision and the branch from code (those informations are also present on the about section)

This is not a super-big commit but I thought it was useful. I'm not sure the git-scmrev.sh script works on Windows tho, I don't have access to a machine with windows right now so I need feedback. I'm also not sure about the informations I put on the about page. Maybe this PR is shit and it was a bad idea from the beginning but it was fun playing with the source code anyway.

dinnme avatar May 29 '21 21:05 dinnme

it doesn't build on Windows, see the CI.

RSDuck avatar Jun 01 '21 12:06 RSDuck

it doesn't build on Windows, see the CI.

Yep I know I mentionned it in the issue. I don't have a windows machine with build tools available right now so unless someone wants to help me with that I will have to wait like a week before being able to do anything

dinnme avatar Jun 01 '21 22:06 dinnme

So, I have not been able to build anything on Windows since and it seems that the codebase changed a bit since may.

I see that #729 mentionned this PR and has a different approach on getting the git revision. I liked the idea of a scmrev.h file that has multiple information about the source revision (SOURCE_CONTROL_REVISION_STRING, SOURCE_CONTROL_DESC_STRING, SOURCE_CONTROL_BRANCH_STRING and SOURCE_CONTROL_IS_STABLE in my commit)

I'm not familiar enough with Windows nor with the codebase to fix my git revision code (using a shell script to create the C header file probably was a weird idea in the first place)

The updater is not finished yet, my About section code clearly is not complex and I can easily refactor it once a durable solution is found. So I propose opening a discussion about how to implement getting the revision, especially with @RayyanAnsari since they managed to implement a cleaner solution, but with less features.

dinnme avatar Oct 21 '21 12:10 dinnme