astro4j icon indicating copy to clipboard operation
astro4j copied to clipboard

Feedback regarding Remote Script Gen

Open vnp85 opened this issue 8 months ago • 3 comments

I'm looking at this documentation, in particular at the JSON fields.

https://melix.github.io/astro4j/latest/fr/jsolex.html#remote-scriptgen

It is more a matter of taste, and having run into issues in my work, I try to promote it (see also the failure of the Mars Climate Orbiter) - to use the unit of measurement in the field names.

It is only by context, and knowing your software to some degree, that I know the unit of measurement for these:

    "detectedWavelen_A": 6562.8099999999995,
    "detectedDispersion_Aperpx": 0.10878780004221283,
    [...]
   "apparentSize_rad",
   "width_px",

   // also l0, b0 and p

Encoding-wise this is going to raise some eyebrows à:

"transformationHistory": {
          "transforms": [
            "Rotation à gauche",

l0 appears multiple times, as a string-float and as a double with many digits angleP idem carrot appears multiple times, but this time it has a funny field name

vnp85 avatar Apr 15 '25 06:04 vnp85

Request, to include into the JSON the input filenames' list (with one, single file or many items for batch processing).

At least in my workflow, filenames would look something like this:

"I:\2025-04-13\Sun-4554_filter-n99--Skywatcher-OtaR62Ap400F\2025-04-13-0728_6-Sun-4554.ser" or "G:\2025-04-13\Sun-FeHe_filter-n99--Skywatcher-OtaR62Ap400F\2025-04-13-1040_3-Sun-FeHe.ser" or "E:\2025-04-13\Sun-4215_filter-n99--Skywatcher-OtaR62Ap400F\2025-04-13-0840_2-Sun-4215.ser"

of which the Sun-4554, Sun-4215, Sun-FeHe are definitely something I'd like to use in my remote script selection/generation.

PS: the sourceInfo looks a bit incomplete for the above

vnp85 avatar Apr 15 '25 06:04 vnp85

So there's intentionally no schema for the JSON at the moment, because, it's a fairly advanced feature which simply dumps the state of the engine. I'm actually quite sure that the docs are not showing the latest version :/ It doesn't contain more than what the engine has access to, but some of the data is filtered out because it makes no sense to expose. I may do this for the transformation history because it's simply a localized version which is for documentation purposes.

The repetition is because there is metadata which is available both globally and on images. For example, a script may load an older image with different P angle and so on, which would be different from the currently processed file.

melix avatar Apr 15 '25 06:04 melix

carrot appears multiple times, but this time it has a funny field name

Didn't even realize when I created that field name :) I's "Carrington rotation" 😂

melix avatar Apr 15 '25 08:04 melix