react-native-snap-carousel icon indicating copy to clipboard operation
react-native-snap-carousel copied to clipboard

fix: viewproptypes export from deprecated prop types

Open yadigarbz opened this issue 2 years ago • 10 comments

Platforms affected

iOS & Android Referencing RN Issue #33734

What does this PR do?

Fixes issue #928

What testing has been done on this change?

All occurrences of ViewPropType import is changed to react-native's new deprecated-react-native-prop-types repo Nothing to test

Tested features checklist

yadigarbz avatar Jul 06 '22 20:07 yadigarbz

Any idea when this might be merged?

abehoffman avatar Jul 11 '22 05:07 abehoffman

Any idea when this might be merged?

Unfortunately no

yadigarbz avatar Jul 11 '22 05:07 yadigarbz

Isn't there a way to do without viewproptype? Because as I see it, it's only a workaround to use deprecated-react-native-proptypes.

Thanks for this PR anyway, I was struggling on this issue today and found this solution too.

Akeuuh avatar Jul 21 '22 20:07 Akeuuh

Isn't there a way to do without viewproptype? Because as I see it, it's only a workaround to use deprecated-react-native-proptypes.

Thanks for this PR anyway, I was struggling on this issue today and found this solution too.

A patch might also be created from my change list if you like. It would be really nice if a maintainer could have looked at it @bd-arc

yadigarbz avatar Jul 22 '22 08:07 yadigarbz

Seems like it can take a lot of time hehe

image

Akeuuh avatar Jul 22 '22 08:07 Akeuuh

To solve the issue temporarily, I have forked this branch and merged it into the fork's master. You can install like:

NPM

npm i git+https://github.com/LarvenLLC/react-native-snap-carousel.git

YARN

yarn add git+https://github.com/LarvenLLC/react-native-snap-carousel.git

Until when the PR is merged.

BossBele avatar Aug 20 '22 11:08 BossBele

@Anthony-Buisson @bd-arc can you please merge this 🙏🏼

amerikan avatar Aug 30 '22 22:08 amerikan

This helped me to solve the issue.

galaxyreal avatar Sep 14 '22 10:09 galaxyreal

The react-native-new-snap-carousel available on npm https://www.npmjs.com/package/react-native-new-snap-carousel https://github.com/bzozoo/react-native-new-snap-carousel

batazo avatar Mar 23 '23 16:03 batazo

praying to the champions of react-native-snap-carousel realm to merge this pr 🙏

aleksandarbos avatar May 05 '23 13:05 aleksandarbos