react-native-render-html icon indicating copy to clipboard operation
react-native-render-html copied to clipboard

ci: update workflows and add deploy workflow

Open DorianMazur opened this issue 1 year ago • 7 comments

Checks

  • [x] I have read the contribution guidelines regarding Pull Requests here: https://git.io/JJ0Pg

Description

This pull request updates the actions in the existing workflows and introduces a new deploy workflow. The new workflow will prepack and release the package to npm.

@jsamr We need to add a new secret named NPM_TOKEN for this process.

DorianMazur avatar Sep 24 '24 11:09 DorianMazur

It looks like there's an issue with Codecov:

[2024-09-24T11:22:04.842Z] ['info'] Detected GitHub Actions as the CI provider.
[2024-09-24T11:22:05.052Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-2.1.0-uploader-0.8.0&token=*******&branch=ci%2Fupdate-workflows&build=11012682270&build_url=https%3A%2F%2Fgithub.com%2Fmeliorence%2Freact-native-render-html%2Factions%2Fruns%2F11012682270&commit=5f68c7378caaeab977e5fdacddd814c3259d9274&job=CI&pr=672&service=github-actions&slug=meliorence%2Freact-native-render-html&name=&tag=&flags=&parent=
[2024-09-24T11:22:05.[28](https://github.com/meliorence/react-native-render-html/actions/runs/11012682270/job/30579399823#step:11:29)7Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 4[29](https://github.com/meliorence/react-native-render-html/actions/runs/11012682270/job/30579399823#step:11:30) - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 241s."}

Could you add the Codecov token to the repository secrets as described here?

Alternatively, we could consider removing this action and switching to something like Jest Coverage Report.

DorianMazur avatar Sep 24 '24 11:09 DorianMazur

The entire release process today is with release-it. See

https://github.com/meliorence/react-native-render-html/blob/be73d811d2418c632ac7b33247ae34f1759924e3/packages/render-html/.release-it.js#L1-L22

It entails the following:

  1. Publish a release to GitHub;
  2. Cut a release to NPM;
  3. Update the documentation website;
  4. Publish the discovery app to expo.

The version 6.4.0 was an accident; only the "publish to GitHub" part worked and I didn't find time to fix the currently broken release process.

I appreciate this PR, but I think we need a proper plan for a new release process first.

jsamr avatar Sep 24 '24 11:09 jsamr

@DorianMazur

Could you add the Codecov token to the repository secrets as described here?

I'm well aware our CI is broken; I am planning on fixing it this weekend; or you may want to take a look. Already did this in https://github.com/native-html/core; just look at recent commits for inspiration (I will have to configure the codecov app for this to work though, but I need approval from a Meliorence org admin, CC @Exilz)

jsamr avatar Sep 24 '24 11:09 jsamr

@DorianMazur To circumvent broken Codecov integration, you may toggle this flag:

https://github.com/meliorence/react-native-render-html/blob/bfc98a91a3f42a207e2e88395487e89aed01da1a/.github/workflows/ci.yml#L40-L43

jsamr avatar Sep 24 '24 13:09 jsamr

@jsamr I don't have the rights on the repository anymore. I think @bd-arc is the only person who does now. Hopefully he can let you set up codecov 😄

Exilz avatar Sep 24 '24 13:09 Exilz

@DorianMazur To circumvent broken Codecov integration, you may toggle this flag:

https://github.com/meliorence/react-native-render-html/blob/bfc98a91a3f42a207e2e88395487e89aed01da1a/.github/workflows/ci.yml#L40-L43

Might want to update codecov/codecov-action@v2 to v4 as well.

qwertychouskie avatar Oct 01 '24 10:10 qwertychouskie

Hi all @jsamr @DorianMazur @qwertychouskie, Seems like this PR has been inactive for a while Is there anything left to do here to have this branch merged?

If so, then please let me know, I will hapily finish it I need that branch in order to have an artifact which I could install And it seems to be blocking future releases

5ZYSZ3K avatar Apr 25 '25 13:04 5ZYSZ3K