react-native-image-gallery icon indicating copy to clipboard operation
react-native-image-gallery copied to clipboard

Add 'onSwipedVertical' and 'onViewTransforming' events

Open infostreams opened this issue 6 years ago • 13 comments

Can be used to close the gallery by swiping up or down ('onSwipedVertical'), and to lighten the background while dragging up ('onViewTransforming')

infostreams avatar Jan 07 '18 14:01 infostreams

Ok, that's it. It's working correctly for me now, I can successfully and easily swipe away a picture to close the gallery.

infostreams avatar Jan 07 '18 14:01 infostreams

@Exilz ~~can you merge this PR please?~~

Sorry! I tested it on a real device (iPhone 7 Plus, RN 0.52.0) and it does not work properly.

Stmol avatar Jan 16 '18 13:01 Stmol

Can you be a bit more specific?

infostreams avatar Jan 22 '18 09:01 infostreams

Any news on this one ? I'd very much like to see it merged 👍

edi avatar Jan 24 '18 12:01 edi

I tried it as well, and something broke somewhere in my merge. Additionally, I'm starting to think that https://github.com/merryjs/photo-viewer is perhaps a better library for my needs... Only works if your project is ejected already though.

infostreams avatar Jan 24 '18 12:01 infostreams

Can you explain what ejected means please ? First time hearing that term.

edi avatar Jan 24 '18 12:01 edi

These guys explain it better than me: https://github.com/react-community/create-react-native-app/blob/master/EJECTING.md

infostreams avatar Jan 24 '18 13:01 infostreams

Ah ok! I was aware of that whole CRNA vs react-native init mess but never knew it's called ejecting. In that case I'm fine, never used CRNA for a project.

Cheers!

edi avatar Jan 24 '18 13:01 edi

For what it's worth, I've now merged the patches correctly and the version at https://github.com/infostreams/react-native-image-gallery/tree/dev is working. It's nowhere near as smooth or nice as the gallery component I linked to above, but it'll do. You can install it as follows

npm install --save "git+https://github.com/infostreams/react-native-image-gallery.git#dev"

Demo with cropped screen of fake profile page: http://gph.is/2GfhKBW

infostreams avatar Jan 25 '18 08:01 infostreams

When is this going to be merged?

dswbx avatar Mar 14 '18 11:03 dswbx

Why not to merge it?

Strate avatar Dec 10 '18 07:12 Strate

plz merge this

devjiro76 avatar Jun 28 '19 08:06 devjiro76

@devjiro76 just fork and publish it yourself. No need to wait for the author.

On Fri, 28 Jun 2019 at 11:07, Devjiro76 [email protected] wrote:

plz merge this

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/archriss/react-native-image-gallery/pull/48?email_source=notifications&email_token=AB23AZK6QFZCHETKZTRYMNTP4XBF5A5CNFSM4EKWVE4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYZMQXY#issuecomment-506644575, or mute the thread https://github.com/notifications/unsubscribe-auth/AB23AZPXDKLWO3MB6WC2ERTP4XBF5ANCNFSM4EKWVE4A .

-- ​​Eduard Duluman F ​ull Stack Developer SC ​ FLEXBOX SRL

Tel: +40 748 891 241 www.duluman.ro http://www.duluman.ro/

edi avatar Jun 28 '19 09:06 edi