Erek Speed comments

Results 199 comments of


                                            Erek Speed

fix: Add logic to return early if hover returns empty string

There is still https://github.com/melink14/rikaikun/pull/1458/files which is similar to this but loses the comments. It'd be nice if you just copied the conents of https://github.com/melink14/rikaikun/pull/1458/files to this branch and then closed...

test: Expand test coverage to background.ts and refactor `sendToBackground` method

> @melink14 Do I need to add these tests changes to their own branch? Will that clean things up? Yes, in this one I would just make a new branch...

Use tabs as the field separator for the dict.dat and names.dat dictionary files

Using a better separator to make parsing logic easier seems good to me. I can't think of any downside to keeping the current logic the same in general. A couple...

Use tabs as the field separator for the dict.dat and names.dat dictionary files

@all-contributors Add @bryanjenningz for ideas.

build(deps): bump eslint-plugin-mocha from 10.2.0 to 10.3.0

@dependabot recreate

refactor(data): Refactor `wordSearch` and other methods for clarity and maintainability

> I did wan't to ask you about that. I have to update my executablePath to make sure pupetteer works correctly. Do you think I should just add it to...

refactor(data): Refactor `wordSearch` and other methods for clarity and maintainability

I see the images are still there but that might be due to the presubmit not re-running to update them. (Since it doesn't re-run when github action pushes a commit)...

refactor(data): Refactor `wordSearch` and other methods for clarity and maintainability

> This hasn't been updated in years but looks like it does what we need it to do? [yomotsu/japanese-string-utils](https://github.com/yomotsu/japanese-string-utils) Maybe we could either use it or get "hints" from it?...

Requests slow/unreliable in 4.2.0-alpha

In order to debug more, are there flags/env variables I can set to get more logging? The next step seems to be profiling browser-request.lua at least. Which seems to be...

Add glossary for definition abbreviations

These can be found in the dictionary FAQ page which I should find and link here.