comfy_mtb icon indicating copy to clipboard operation
comfy_mtb copied to clipboard

[bug] Animation builder doesn't work properly when total_frames is an input connected to INT type output

Open ali1234 opened this issue 1 year ago • 2 comments

Describe the bug

When animation builder's total_frames is set to an input and connected to a node which outputs an int, the total frames is always 100, and not the value that the node output. Note that this does not happen with primitive nodes.

Reproduction

  1. Add an animation builder.
  2. Connect frame output to MTB debug.
  3. Convert total_frames to an input.
  4. Add a math node like IntUnaryOperation and connect it to total frames.
  5. Click "queue" on animation builder.

Result: animation builder always thinks that there are 100 frames in total.

Expected behavior

Animation builder should queue the number of prompts output by the math node.

Operating System

Linux

Comfy Mode

In a custom virtual env (venv, virtualenv, conda...)

Console output

No response

Additional context

Example workflow:

workflow-anim-builder-bug

ali1234 avatar Sep 08 '23 19:09 ali1234

i got a problem with the animation builder, the node didn't show the Reset and Queue bottom, how can i solve this problem, uhhh,

Bearoar avatar Sep 23 '23 09:09 Bearoar

@Bearoar please open a dedicated issue it's not related.

@ali1234 This one that is probably due to a ComfyUI update but I haven't been able to dedicate time for it last week probably next week

melMass avatar Sep 24 '23 10:09 melMass

I can confirm this is still a thing.

Immac avatar Jun 04 '24 02:06 Immac

I'm going to release a long video, hopefully soon where I will go over those limitations and explain workarounds.

The TLDR is that I use a mix of client and server methods. For it to work properly it must only be used with nodes that have a python backend, those are called non virtual nodes in comfy

melMass avatar Jul 02 '24 11:07 melMass