melMass
[feat] Fix note+
Describe the problem
It completely broke in a recent comfy update and there is now a buitlin equivalent. This will remove A LOT of js code from mtb which is nice. I tried to do it quickly but it's more involving then expected
Describe the solution you'd like
- If possible deprecate first then remove but I don't think there is a way for frontend only nodes.
- Find a way to handle serialized note+ to convert them to the builtin one on opening old worflows
Alternatives considered
The issue is that the hack from https://github.com/melMass/comfy_mtb/blob/af421340286b234e4c0cfcd4143a9d8726ebf3d1/web/note_plus.js#L149 doesn't work anymore.
And the whole DOM element block pointer events (that I use for both dragging notes and opening the editor)
Additional context
No response
would love some instructions to bypass this. after loading a workflow that had this kind of node, i can no longer move/load workflows because the error keeps popping up
remove note+ is ok for me, the how to open my old workflows? any suggestion?
Thanks for the reports, I'll look into it today and either solve the issue or effectively remove it with a fallback
@RhaoG @K-O-N-B update mtb and it should work fine. The issue (#239) was unrelated to node+ being broken in the latest frontend
new markdown nodes is cool by its own, but not covering my usecase I liked note+ for clean blocks of text that i could see form far to have birdeye view of my workflow.
@NOTlinnkoln Thanks for the feedback! I will look into it as I noticed that too and as I'm fully revamping the examples of mtb I will need these notes.
@scofano Bummer... I'm busy until Friday but I will look into fixing note+ asap. It's finicky but try the top right border of the node... The TDLR is that they changed the order of events in the comfy frontend which broke note+
https://github.com/user-attachments/assets/a2bfe367-e328-439d-ba5d-4ae60108c655
@melMass Thanks for the video, (and for the outstanding nodes). I had a previous version of the workflow, so I deleted the one that had it and updated the previous one. =)
Take your time.
I finally got time to look into this and made a bunch of improvements on top of fixing it. I will release it tomorrow (after testing it a bit more)
https://github.com/user-attachments/assets/914bc27c-6c11-471a-b794-c48e04c905f8