comfy_mtb icon indicating copy to clipboard operation
comfy_mtb copied to clipboard

[bug] Note+ strips html attributes?

Open fuzhao119 opened this issue 1 year ago • 7 comments

Describe the bug

The target attribute in a <a> link is stripped

Reproduction

This:

<a href="https://xxx" target="_blank"></a>.

Is turned into this on save of Note+:

<a href="https://xxx"></a>.

Expected behavior

Not stripping attributes

Operating System

Windows (Default)

Comfy Mode

Comfy Portable (embed) (Default)

Console output

No response

Additional context

No response

fuzhao119 avatar Sep 05 '24 12:09 fuzhao119

After clicking the SAVE button, changes to

fuzhao119 avatar Sep 05 '24 12:09 fuzhao119

I think you forgot something. I have no idea what you are referring to

melMass avatar Sep 05 '24 12:09 melMass

I guessed what you meant and rewrote the issue

melMass avatar Sep 05 '24 12:09 melMass

This is true for the HTML mode, I will check what makes sense to allow. For markdown, _blank is the default, so this would do what you want:

## Note+
Go here [site](https://www.xxx.com)

Markdown is the preferred mode as it should be a superset of HTML in Note+

melMass avatar Sep 05 '24 12:09 melMass

My purpose is to open a window in a new tab, rather than refreshing the current comfyui page

fuzhao119 avatar Sep 11 '24 01:09 fuzhao119

test

fuzhao119 avatar Sep 11 '24 01:09 fuzhao119

@melMass

fuzhao119 avatar Sep 11 '24 12:09 fuzhao119

I'm closing it just to do some cleanup. When #211 will be merged, _blank will be the default for a tags

melMass avatar Nov 17 '24 22:11 melMass