jquery-ui-notification icon indicating copy to clipboard operation
jquery-ui-notification copied to clipboard

Alterations

Open danheberden opened this issue 13 years ago • 3 comments

Adjusted the markup to use a div with ui's css frame work instead of h4/p tags that might get some crazy styling from the page.

danheberden avatar Feb 14 '11 04:02 danheberden

Good idea, badly executed! ;)

The point behind using h4 and p elements is because they are supposed to inherit styles from the rest of your page. If it looks like crap you can easily change the css or just change the template. So I'm not convinced that this change is necessary at all, but would be interesting to hear your case.

mekwall avatar Feb 14 '11 07:02 mekwall

sry for the poor execution. perhaps I was mistaken that this was designed as a jquery-ui type plugin and not just jquery ui as in a vanilla UI term.

My case, assuming the former, would be that dialog doesn't use h4 and p tags. Of course you could style any element however you want to, I was just pointing out the jquery ui css framework as an option. But I think I mis-understood the title of the repo and blog post, so my apologies :) It works great, btw - fantastic work!

danheberden avatar Feb 14 '11 07:02 danheberden

Dan, your point is valid and I'm going to take it into consideration when overhauling the templating part of the plugin (add support for $.tmpl). We also need to find a solution to the nesting widget styles pointed out by ajpiano. Overhauling the widget layout might be necessary.

mekwall avatar Feb 14 '11 12:02 mekwall