openmrs-module-initializer icon indicating copy to clipboard operation
openmrs-module-initializer copied to clipboard
verified publisher icon mekomsolutions

Fix LiquibaseLoaderIntegrationTest

Open mogoodrich opened this issue 3 years ago • 2 comments

I noticed when running tests that the LiquibaseLoaderIntegrationTest was failing for me when running all the tests via Maven. Looking at the test, I saw a comment and some code ignoring when running github actions.

I think I figured out the error: the DeleteDomainChecksumsChangesetIntegrationTest was polluting the context somehow, and so if it happened to run before the LiquibaseLoaderIntegrationTest the latter fails.

I was able to fix it by changing the name the liquibase files used (see PR) though the "proper" fix would likely be to fix the DeleteDomain test to clean up it's context.

fyi @ibacher

mogoodrich avatar Sep 27 '22 21:09 mogoodrich

But now github actions is failing on this test: "load_shouldLoadFormWithAllAttributesSpecified(org.openmrs.module.initializer.api.form.HtmlFormsLoaderIntegrationTest)" ... but I'm not seeing this locally... so this may not help things... @ibacher @mks-d I'm happy to just close this out without merging, but worth you taking a look at it first to see if it's helpful at all.

mogoodrich avatar Sep 27 '22 21:09 mogoodrich

Looks like this is still necessary (i.e., we're skipping this test on GH Actions).

ibacher avatar Jul 01 '24 16:07 ibacher