Bruno Kolenbrander

Results 76 comments of Bruno Kolenbrander

I like how https://rustwasm.github.io/docs/book/ approaches this. Very friendly to people new to Rust.

I was thinking - can we use this to avoid having to acquire the GIL for things like `Py`'s `Display` and `Serialize` impls? Also, I plan on rewriting the docs...

> A thought... should this be called `#[pyclass(frozen)]`? That mirrors the python api a lot better 👍 What should we name the Mutability/Mutable/Immutable traits and structs then? Those are user-visible.

I love this, thanks ❤️ > One thing that bugs me at the moment is that deeply nested collections look really convoluted because of all the py's and result handling:...

I prefer the original syntax, e.g. `py_list!(py, [1, 2, 3])`. I don't get the meaning of this `=>` syntax. > we should aim to choose just one syntax. I agree...

👍 Does that mean `GILGuard` will be deprecated/private entirely?

> This makes no sense to me - even if people are forced to use a function sometimes, it needs to be unsafe if we can't guarantee safety. It absolutely...

I mean, I agree with all those things. I'm just saying that if we need to have an api like that it would be nice if it could be safe.

I'd like to get the deprecation merged and do these optimizations in the future - are there any outstanding concerns around this? Also, I've been thinking about supporting subinterpreters and...

Are you working on a rebase right now? Otherwise I'll just open a new PR with these changes.