YOLOv6 icon indicating copy to clipboard operation
YOLOv6 copied to clipboard

Allow images with upper case file extensions. e.g. foo.JPG

Open jim-meyer opened this issue 2 years ago • 3 comments

jim-meyer avatar Jul 30 '22 12:07 jim-meyer

Thanks for pr. But currently IMG_FORMAT is used with .lower() . So images with upper case file extensions will cause no trouble.

shensheng272 avatar Aug 04 '22 07:08 shensheng272

@shensheng272 There is a bug here where the code is not using .lower(). So either that line needs to be changed to call .lower(), or IMG_FORMAT needs to include both upper and lower case versions of the supported extensions. I though changing IMG_FORMAT was a more robust solution to avoid future problems like this. Would you rather I submit a PR for fixing that line of code instead?

There is a similar problem here too hence my suggested change to that file.

jim-meyer avatar Aug 04 '22 12:08 jim-meyer

@shensheng272 There is a bug here where the code is not using .lower(). So either that line needs to be changed to call .lower(), or IMG_FORMAT needs to include both upper and lower case versions of the supported extensions. I though changing IMG_FORMAT was a more robust solution to avoid future problems like this. Would you rather I submit a PR for fixing that line of code instead?

There is a similar problem here too hence my suggested change to that file.

Thanks for reply. Your example of vis_dataset is right. You might submit a PR for fixing that line of code of vis_dataset.py instead. Sorry for my careless check.

shensheng272 avatar Aug 05 '22 05:08 shensheng272