cypress-plugin-snapshots icon indicating copy to clipboard operation
cypress-plugin-snapshots copied to clipboard

Published 20 hours ago • verified publisher icon meinaart

Fix failure handling in spec retry

Open kpdecker opened this issue 3 years ago • 3 comments

When running in retry mode with a failing snapshot, we would see the expected failure on the first attempt. On the second attempt this would pass as the numeric ID for the snapshot was incremented, creating a new snapshot.

This PR changes behavior so that

  • Snapshots are not written if autopassNewSnapshots is false
  • Snapshot id trackers are reset after test completion

kpdecker avatar Jun 16 '21 20:06 kpdecker

Nice trick ! I did think about resetting after test completion !

edimitchel avatar Jun 23 '21 13:06 edimitchel

@edimitchel what about merging this pr?

ollybondareva avatar Oct 29 '21 09:10 ollybondareva

I cannot, build is not passing and I cannot change anything on project for be able to do...

edimitchel avatar Oct 29 '21 10:10 edimitchel