meilisearch icon indicating copy to clipboard operation
meilisearch copied to clipboard
verified publisher icon meilisearch

Replace hardcoded string with constants

Open Gnosnay opened this issue 1 year ago • 2 comments

Pull Request

Related issue

Fixes #5136

What does this PR do?

  • Replace all of hardcoded "_geo" to one constant string.

PR checklist

Please check if your PR fulfills the following requirements:

  • [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [x] Have you read the contributing guidelines?
  • [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Gnosnay avatar Dec 16 '24 18:12 Gnosnay

Hey @Gnosnay, I just reviewed your PR and it's perfect as-is. We have a big rebase of release-v1.12.0 on main planned by the end of the week and I would like to make it as smooth as possible since the code is quite complex. If that works for you, I would like to merge your PR after the rebase at the beginning of next week :pray:

irevoire avatar Dec 17 '24 12:12 irevoire

Hey @Gnosnay, I just reviewed your PR and it's perfect as-is. We have a big rebase of release-v1.12.0 on main planned by the end of the week and I would like to make it as smooth as possible since the code is quite complex. If that works for you, I would like to merge your PR after the rebase at the beginning of next week 🙏

thx for your reply. sure~ it is okie to me.

just let me know if there is any conflicts in the future

Gnosnay avatar Dec 17 '24 14:12 Gnosnay

do let me know if this pr requires more help to be proceeded

Gnosnay avatar Dec 23 '24 05:12 Gnosnay

Hey @Gnosnay, it's done: https://github.com/meilisearch/meilisearch/pull/5187 The change of the last release was brought to main, and you can rebase, then I'll merge your PR. Thanks again for your interest in the project!

irevoire avatar Dec 23 '24 13:12 irevoire

Hey @Gnosnay, it's done: #5187 The change of the last release was brought to main, and you can rebase, then I'll merge your PR. Thanks again for your interest in the project!

@irevoire hi master, i rebased the branch, pls help have one look. many thanks

Gnosnay avatar Dec 23 '24 16:12 Gnosnay

hi @irevoire , thank you for your reply. i have fixed the format issue. please have one look.

happy holiday btw

Gnosnay avatar Dec 28 '24 12:12 Gnosnay

Build succeeded:

meili-bors[bot] avatar Dec 30 '24 14:12 meili-bors[bot]