meilisearch-ruby icon indicating copy to clipboard operation
meilisearch-ruby copied to clipboard

Federated search added (#558)

Open Nymuxyzo opened this issue 1 year ago • 1 comments

Pull Request

Related issue

Fixes #558

What does this PR do?

  • Federated search added

PR checklist

Please check if your PR fulfills the following requirements:

  • [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [x] Have you read the contributing guidelines?
  • [x] Have you made sure that the title is accurate and descriptive of the changes?

Nymuxyzo avatar Oct 11 '24 23:10 Nymuxyzo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9123ebb) to head (01a293b). Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #567   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          749       752    +3     
=========================================
+ Hits           749       752    +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 11 '24 23:10 codecov[bot]

Thanks for the contribution! Good job on the documentation comment, we should add those for the entire gem.

A few things regarding git:

* Try to write commit messages in [imperative sentences](https://www.grammarly.com/blog/sentences/imperative-sentences/)
  `Federated search added` ❌
  `Add federated search` ✔️

* Use git rebase to clean up the git history.

If you are new to git or unsure how to do this, feel free to reach out to me.

Commit message rewritten and git rebase executed

Nymuxyzo avatar Oct 30 '24 00:10 Nymuxyzo

@ellnix can you make the last test to ensure the federation is working?

brunoocasali avatar Jan 08 '25 16:01 brunoocasali

@Nymuxyzo

I don't mean to bother you, but it would be nice if this was finished. If you don't have time I can take over, we would be grateful for the work you have done and of course you would have full commit credit for the work you have done so far :heart:

I'll give you a couple more days to respond, thank you again for your contribution and involvement.

ellnix avatar Jan 28 '25 18:01 ellnix

@Nymuxyzo I'll get this PR done. If you would like to still take a shot at it, please let me know in the next hour.

ellnix avatar Jan 30 '25 14:01 ellnix

@brunoocasali I think I implemented our suggestions, let me know if there's something wrong or missing. Otherwise, I think we can merge it.

ellnix avatar Jan 30 '25 16:01 ellnix

Hi @brunoocasali @ellnix, I really don't mean to bother you, but is there anything else needed to get this over the line?

wesharper avatar Feb 04 '25 17:02 wesharper

@wesharper It's out of my control, I'm waiting on reviews on this PR and quite a few others in this repo.

ellnix avatar Feb 04 '25 20:02 ellnix

@ellnix No problem, thanks for the effort. I definitely sympathize with folks who are balancing full-time gigs and open-source maintenance, so I try to assume the best. I'll try to curb my impatience on this. Any urgency on my end is due in larger part to my excitement than frustration.

wesharper avatar Feb 04 '25 21:02 wesharper

bors merge

brunoocasali avatar Feb 05 '25 01:02 brunoocasali

Build succeeded:

meili-bors[bot] avatar Feb 05 '25 01:02 meili-bors[bot]