Federated search added (#558)
Pull Request
Related issue
Fixes #558
What does this PR do?
- Federated search added
PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
9123ebb) to head (01a293b). Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #567 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 749 752 +3
=========================================
+ Hits 749 752 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the contribution! Good job on the documentation comment, we should add those for the entire gem.
A few things regarding git:
* Try to write commit messages in [imperative sentences](https://www.grammarly.com/blog/sentences/imperative-sentences/) `Federated search added` ❌ `Add federated search` ✔️ * Use git rebase to clean up the git history.If you are new to git or unsure how to do this, feel free to reach out to me.
Commit message rewritten and git rebase executed
@ellnix can you make the last test to ensure the federation is working?
@Nymuxyzo
I don't mean to bother you, but it would be nice if this was finished. If you don't have time I can take over, we would be grateful for the work you have done and of course you would have full commit credit for the work you have done so far :heart:
I'll give you a couple more days to respond, thank you again for your contribution and involvement.
@Nymuxyzo I'll get this PR done. If you would like to still take a shot at it, please let me know in the next hour.
@brunoocasali I think I implemented our suggestions, let me know if there's something wrong or missing. Otherwise, I think we can merge it.
Hi @brunoocasali @ellnix, I really don't mean to bother you, but is there anything else needed to get this over the line?
@wesharper It's out of my control, I'm waiting on reviews on this PR and quite a few others in this repo.
@ellnix No problem, thanks for the effort. I definitely sympathize with folks who are balancing full-time gigs and open-source maintenance, so I try to assume the best. I'll try to curb my impatience on this. Any urgency on my end is due in larger part to my excitement than frustration.
bors merge
Build succeeded:
- integration-tests (ruby 3.1)
- integration-tests (ruby 3.2)
- integration-tests (ruby 3.3)
- linter-check