meilisearch-python icon indicating copy to clipboard operation
meilisearch-python copied to clipboard

[v1.6] Support `proximityPrecision` setting

Open curquiza opened this issue 1 year ago • 2 comments

Following this central issue

This is related to a newly introduced feature in Meilisearch v1.6.0: the proximity-precision setting.

Refer to docs for more information.

  • [ ] Add the new settings: proximityPrecision with get, update, and reset methods associated. Here are the JS equivalents in meilisearch-js you should create for this repository:
client.index('indexName').getProximityPrecision(); // calls GET /indexes/:uid/settings/proximity-precision
client.index('indexName').updateProximityPrecision('byAttribute');  // calls PUT /indexes/:uid/settings/proximity-precision
client.index('indexName').resetProximityPrecision(); // calls DELETE /indexes/:uid/settings/proximity-precision
  • [ ] The methods associated with the /settings API route (to get, reset and update the settings globally) must be able to receive in the payload the new proximityPrecision field
  • [ ] ⚠️ Add integration tests ⚠️
  • [ ] Update the .code-samples.meilisearch.yaml
    • [ ] Add get_proximity_precision_settings_1 key and “translate” the following curl example by using the newly added methods: https://github.com/meilisearch/documentation/blob/cd9598324329d20d23f1d9200c6c537acaf01f3e/.code-samples.meilisearch.yaml#L1150-L1152
    • [ ] Add update_proximity_precision_settings_1 key and “translate” the following curl example by using the newly added methods: https://github.com/meilisearch/documentation/blob/cd9598324329d20d23f1d9200c6c537acaf01f3e/.code-samples.meilisearch.yaml#L1153-L1157
    • [ ] Add reset_proximity_precision_settings_1 key and “translate” the following curl example by using the newly added methods: https://github.com/meilisearch/documentation/blob/cd9598324329d20d23f1d9200c6c537acaf01f3e/.code-samples.meilisearch.yaml#L1158C1-L1160

curquiza avatar Jan 15 '24 18:01 curquiza

@curquiza I want to work on this.

geeksambhu avatar Feb 05 '24 06:02 geeksambhu

Thanks for your interest in this project 🔥 You are definitely more than welcome to open a PR for this!

For your information, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors from opening a PR to fix this issue. We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.

We are looking forward to reviewing your PR 😊

curquiza avatar Feb 05 '24 09:02 curquiza