meilisearch-php
meilisearch-php copied to clipboard
Implement methods for CSV and Ndjson batch adds
Pull Request
Related issue
Fixes #238
What does this PR do?
- Implements methods for batch adding of documents in csv and ndjson format
PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Notes
This is using preg_split
and implode
to chunk strings by newline. Let me know if there is a better way to do this.
If this is fine I can implement the rest of the methods from the issue.
Hello @karlomikus, Thank you very much for contributing to Meilisearch :heart:. However, I am not available on the weekend, but I will be back on Monday :blush:.
PS: This message was sent automatically!
@karlomikus I tried to merge, but we still have some issues to fix regarding the phpstan can you check that? :)
bors merge
I've fixed phpstan errors, I completely missed them :)
I think contributing guidelines should be updated to include composer phpstan
run command.
Build succeeded:
- integration-tests (PHP 7.4)
- integration-tests (PHP 8.0)
- integration-tests (PHP 8.1)
- linter-check
- phpstan-tests
This message is sent automatically
Thanks again for contributing to Meilisearch :heart: If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.