meilisearch-java
meilisearch-java copied to clipboard
meilisearch
#256 ndjson/csv methods to add
Pull Request
What does this PR do?
Added addDocumentsCSV and addDocumentsNDJSON methods with respective tests. Added addDocumentsCSVinBatches and addDocumentsNDJSONinBatches methods with respective tests. Fixes #256
PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to MeiliSearch!
Thanks @diegonavarroq for the PR, @alallema will review it when she will have the time
@alallema, #256 should NOT be closed when this PR si merged since all the methods will not be implemented yet
I have a problem with integration tests because when I do those tests locally it passes them but when I commit and push it fails and I have no way of seeing what causes them to fail, I would appreciate a little help with that. This is happening in PR #309 and #312. @curquiza @alallema
Hi @diegonavarroq, Indeed, the last release of Meilisearch took place last week. So tests are now running with Mielisearch v0.25.0. So sorry for the inconvenience. I currently updating this SDK I think the best to merge your PR is to wait until I finish this update and I will take care of integrating your code afterward if it's ok for you.
Hi @diegonavarroq, Sorry for the delay. SDK update is done, is it ok for you if I handle all conflicts in GitHub, or would you rather do it? Thank again for the PR ❤️
Hi @diegonavarroq, Sorry for the delay. SDK update is done, is it ok for you if I handle all conflicts in GitHub, or would you rather do it? Thank again for the PR ❤️