meilisearch-go icon indicating copy to clipboard operation
meilisearch-go copied to clipboard

Fix Locates Typo

Open zanmato opened this issue 6 months ago • 2 comments

This fixes the Locates => Locales typo

PR checklist

Please check if your PR fulfills the following requirements:

  • [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [x] Have you read the contributing guidelines?
  • [x] Have you made sure that the title is accurate and descriptive of the changes?

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a typo in the search request parameter from "Locates" to "Locales" across the interface and code samples, ensuring proper locale filtering in search queries.

zanmato avatar Jun 27 '25 07:06 zanmato

Walkthrough

A typo in the SearchRequest struct was corrected across the codebase, changing the field name from Locates to Locales. This update was applied in the struct definition, related JSON (de)serialization code, a test case, and a YAML code sample, ensuring consistent usage of the correct field name for locale filtering.

Changes

File(s) Change Summary
types.go Renamed Locates field to Locales in SearchRequest struct and updated JSON tag accordingly.
types_easyjson.go Updated all marshal/unmarshal logic to use Locales instead of Locates for the relevant field.
index_search_test.go Updated test case to use Locales instead of Locates in SearchRequest input.
.code-samples.meilisearch.yaml Fixed typo in code sample, changing Locates to Locales in search request parameter.

Poem

A rabbit hopped through fields of code,
Spotting "Locates" where "Locales" should goad.
With a twitch of its nose and a flick of its ear,
The typo was fixed—now all is clear!
Search requests now travel the right locale,
Thanks to a bunny on a debugging trail.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87f1963b7e2a9861f717eb2994387d7dbf183c86 and 79145ebc9193123c4f5ba16c949589eff22addf9.

📒 Files selected for processing (1)
  • index_search_test.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • index_search_test.go
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 27 '25 07:06 coderabbitai[bot]

@zanmato Thank you for contributing. Please wait for the merge of the changes in PR https://github.com/meilisearch/meilisearch-go/pull/609.

ja7ad avatar Jun 27 '25 17:06 ja7ad

@zanmato Please get last changes of main then fix conflicts.

ja7ad avatar Jul 08 '25 07:07 ja7ad

Merge conflict.

meili-bors[bot] avatar Jul 08 '25 07:07 meili-bors[bot]

There is not activity for this PR, in another PR will be fix it.

ja7ad avatar Jul 18 '25 16:07 ja7ad