meilisearch-go
meilisearch-go copied to clipboard
Replace all `map[string]interface{}` by the type created for this purpose `Unknow`
An "unknown" type is available in the type list but it has not been used or very little in this SDK.
It could be great and cleaner to replace all the map[string]interface{}
with Unknow
// Unknown is unknown json type
type Unknown map[string]interface{}
I can work on this issue, but it shows Version dependency
Hi @shadowshot-x, Please, go for it I edit the issue it was a old comment 😃
Awesome. Thank you @alallema
Hi @alallema, should a PR closing this issue change the types of the public APIs too or should changes be limited to internal uses of map[string]interface{}
?
i.e. should something like GetRawIndex
return meilisearch.Unknown
instead of map[string]interface{}
?
I imagine those might be considered breaking changes?
Hi @a11rew, Thanks for the question, indeed I was just thinking of changing the internal type only to avoid breaking and not forcing people to use our specific type.