documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Vale next steps

Open maryamsulemani97 opened this issue 2 years ago • 2 comments

https://github.com/meilisearch/documentation/pull/1646 adds basic rules to the docs. We will be updating these rules and adding new ones over time. The full list of current+possible rules can be found in Notion.

The next step is to fix the following current rules:

Add new rules:

  • [ ] ~~No capitals after colons in sentences~~
    • Too many exceptions
  • [x] Decide max sentence length (most rules use 25-30)
    • Most of our “longer” (more than 25 words) sentences are between 27-30 words. The longest are ~42. We can start with a max sentence length of ~40 words and see how that goes. #1777
  • [ ] Sound less condescending. See discussion here: https://github.com/meilisearch/documentation/pull/1662

Start working on:

  • [ ] a list of words to replace to avoid wordy sentences (e.g., replace in order to with to)
  • [x] a list of US vs British spelling so we follow US English #1775
  • [ ] ~~consider if we need any readability metrics~~
    • Not very helpful, they just give you a number and you have to figure out what to fix

maryamsulemani97 avatar Jun 09 '22 13:06 maryamsulemani97

Once these steps have been achieved, and we've done sufficient iteration on the rules to be sure they will not create false positives, we will move to the final step: add Vale to our checks CI.

dichotommy avatar Jun 13 '22 10:06 dichotommy

To be done:

  1. We currently have 28 warnings and 36 suggestions
  • 4 warnings for using indexation instead of indexing
  • 2 suggestions for the Oxford comma
    • The Oxford comma rule does not work as intended for complex sentences with many commas. This is also mentioned in the OxfordComma.yml file.
  • 19 suggestions for the First person rule. Most of the pages that have this suggestion will be moved to the Developer hub
  • 10 suggestions for using the semicolon. We will need to rewrite these sentences
  • 5 suggestions for the Heading rule (use sentence-style capitalization). There are some headings where we don't follow this format:
    • "Meilisearch Documentation" in index.md
    • "Recommended: "Previous" and "Next" buttons" in learn/advanced/pagination.md
  • 24 warnings for typos; most of these are intentional

Screen Shot 2022-10-04 at 14 11 20

You will only get all these warnings and suggestions if you run vale . locally on the docs. The Vale action only shows an error/warning/suggestion if you break any of the rules in the content you added or edited.

  1. Update sentences to sound less condescending
  2. A list of words to replace to avoid wordy sentences (e.g., replace in order to with to)
  • This isn't a high priority as we haven't identified such phrases yet

maryamsulemani97 avatar Oct 04 '22 10:10 maryamsulemani97

Closing this for https://github.com/meilisearch/documentation/issues/1939

maryamsulemani97 avatar Oct 18 '22 11:10 maryamsulemani97