charabia icon indicating copy to clipboard operation
charabia copied to clipboard

Published 20 hours ago • verified publisher icon meilisearch

Adds a new normalizer to normalize œ to oe and æ to ae

Open Soham1803 opened this issue 1 year ago • 6 comments

Pull Request

Related issue

Fixes #268

What does this PR do?

  • Creates a new normalizer ae_oe_normalizer
  • normalizes œ and Œ to oe, æ and Æ to ae.

PR checklist

Please check if your PR fulfills the following requirements:

  • [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [x] Have you read the contributing guidelines?
  • [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Soham1803 avatar Apr 06 '24 14:04 Soham1803

Hello @Soham1803, Thank you for your PR, I made several change requests before accepting to merge it,

let me know if you need more informations

ManyTheFish avatar Apr 16 '24 09:04 ManyTheFish

Hey @ManyTheFish I have made the requested changes can you please check and let me know. Thank You!

Soham1803 avatar Apr 26 '24 10:04 Soham1803

Hello @Soham1803,

The tests don't seem to work. Could you fix them?

Thank you

ManyTheFish avatar Apr 29 '24 08:04 ManyTheFish

Build failed:

  • tests

meili-bors[bot] avatar Apr 29 '24 08:04 meili-bors[bot]

Hey @ManyTheFish, I'm trying to run the tests on my local machine but got some issues with jemalloc-sys in .cargo. The last commit I made is based on the logs of test run I read on Github. Its good if the tests pass now, or else I will make another commit after being assured all the tests are passed.

Soham1803 avatar Apr 29 '24 12:04 Soham1803

Hey @ManyTheFish sorry for the delay. Thanks for your suggested changes. The last commit passed all the tests on local successfully, after many different tryouts. Made some major changes to the Normalizer. Suggest me any changes if necessary before the merge.

Thank You!

Soham1803 avatar May 03 '24 16:05 Soham1803

Hello @Soham1803

@ManyTheFish is on Holidays and will review your PR when coming back

In the meantime, can you fix the Rustfmt tests? 😊

Thanks again for your PR

curquiza avatar May 06 '24 08:05 curquiza

Hello @curquiza, dealt with the Rustfmt tests. I guess all tests are passed. Now, just waiting for @ManyTheFish to suggest any required changes before the merge.

Thank You! 😊

Soham1803 avatar May 06 '24 17:05 Soham1803

Build succeeded:

meili-bors[bot] avatar May 21 '24 12:05 meili-bors[bot]

Nice to have you back @ManyTheFish. Thanks for accepting my PR and the help you provided. 😊

Soham1803 avatar May 21 '24 14:05 Soham1803