androminion icon indicating copy to clipboard operation
androminion copied to clipboard

Crashes periodically with this card combination including Changling

Open kencorbin opened this issue 6 years ago • 1 comments

Looks like you need a check for an empty array. This is the pre-alpha version 5 version.

01-25 19:26:33.727 23585 28371 E AndroidRuntime: FATAL EXCEPTION: Thread-19 01-25 19:26:33.727 23585 28371 E AndroidRuntime: Process: com.mehtank.androminion, PID: 23585 01-25 19:26:33.727 23585 28371 E AndroidRuntime: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at java.util.ArrayList.get(ArrayList.java:437) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.BasePlayer.changeling_cardToGain(BasePlayer.java:4537) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.CardImplNocturne.changeling(CardImplNocturne.java:321) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.CardImplNocturne.additionalCardActions(CardImplNocturne.java:36) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.CardImpl.play(CardImpl.java:838) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.CardImpl.play(CardImpl.java:728) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.Game.playNight(Game.java:557) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.Game.start(Game.java:382) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.Game.go(Game.java:224) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at com.vdom.core.VDomServer$GameStarter.run(VDomServer.java:47) 01-25 19:26:33.727 23585 28371 E AndroidRuntime: at java.lang.Thread.run(Thread.java:764) 01-25 19:26:33.735 1153 2855 W ActivityManager: Force finishing activity com.mehtank.androminion/.activities.GameActivity

I would love to run bleeding edge current source version, but have not figured out your build process :(

kencorbin avatar Jan 26 '19 03:01 kencorbin

I've found the problem. You must gain a copy af a card when trashing changeling. The method changeling_cardToGain only gains good cards ignoring bad cards. I'll make a PR this day.

Because I'm coding on my smartphone, I'm not sure of what I'm saying. To build androminion, you should use Eclipse with ADT plugin.

ghost avatar Feb 20 '19 08:02 ghost