androminion
androminion copied to clipboard
mehtank
Implement Nocturne
This is a placeholder issue for implementing the upcoming Nocturne expansion functionality. As no features or cards from Nocturne have been fully revealed, implementation on this will wait until the release of Nocturne, which has no set date, but is scheduled to release sometime in October. Implementation of the new features, including Night, Heirloom, Fate and Doom cards, will have to wait until after then.
Here are the previewed cards from Nocturne.
There was heavy refactoring made to support Duration and Throne Room variants to improve tracking and simplify parts of the code. Also, many changes were made to trashing cards to support Necromancer and the corresponding lose-track situations. Also includes the upcoming Dismantle Promo card.
Issues can be reported here directly for the time being until all the Nocturne cards get done and the major issues are resolved.
https://github.com/mehtank/androminion/releases/tag/v8.00-prealpha-0
I've added Spanish translations for all the new Nocturne stuff. Pre-alpha is here: https://github.com/mehtank/androminion/releases/tag/v8.01-prealpha1
Android 6.0; v8.00-prealpha-0
========== ISSUES
-
Raider... Players with 5 cards are not discarding nor revealing their hand I'm assuming those opponents don't have anything to discard, but they should be revealing their hands. In one case, Earl, the next player is doing so after I only play a Blessed Village and Platinum (he reveals Copper, Silver, Duchy, and 2 Provinces), but not the other 4 opponents
-
Crypt... Colony got moved from Hand to "Played" column
-
Colony is "grayed out" in the Played column at start of turn Reproducing this should entail: --play a Fool next turn, Colony was "played", but not "in play". Note that this game did have P/C enabled
========== INCORRECT TEXT 4) Crypt... text is saying to pick a card, when it should be just Treasures App still follows the rules on only Treasures though
- The Sky's Gift... Tells me to pick exactly 2 cards to discard, even though text says 3 I only have 2 cards in hand. Correct behavior enforced (no Gold gained)
@ayao44 Fixed issue with Raider (item 1): d0551c69225f326b370348e8af98123734d28fe4 Fixed issue with extra cards showing up as it play while having Lost in the Woods (your items 2 and 3): ea217f0ce8bb8ecbe81d3353b49e9701815b627d
I'm not able to reproduce item 4 on Crypt - it shows up as select treasures for me. Maybe you could give me some more details on how to reproduce?
As for item 5, that may require a bit of re-working the UI code as it checks the current number of cards in hand to display as the max number to choose, even if the subsequent effect (gaining the Gold in this case) is contingent on choosing the entire number of cards, even if you currently can't. This would also be the case for other effects that require an exact number of cards chosen when you don't have that many, such as Quest. I'll see what I can do, as this is still confusing...
All the cards from Nocturne are done! Recommended sets are added as well.
https://github.com/mehtank/androminion/releases/tag/v8.02-prealpha2
Try it out and report any issues you find.
Fixed issue with Mint crashing game when bought.
New release: https://github.com/mehtank/androminion/releases/tag/v8.04-prealpha4
Just for your information, Minusik has updated his Jack of All Dominion app with the Nocturne cards.
This app allows you to select random kingdoms as well as manually place cards into a kingdom and launch Androminion with the chosen cards. This should be helpful for anyone trying to test the Nocturne pre-release. Also, you can now manually add Events and Landmarks as well (wasn't possible in the prior version).
I've completed French translations
for version 8.04. I made some changes
- Skulk : Malandrin is replaced by Coupe-jarret, as Malandrin is already used to translate Bandit from Base 2nd Edition (Bandit is the official translation for Rogue),
- Boon : Aubaine is replaced by Bienfait, as Aubaine is already used to translate the Windfall event,
- Hex : Sortilège is replaced by Maléfice (which is a harmful spell for its target). Again, a big thank you for your work, dominionator. values-fr.zip
@oboulonis Thanks for your efforts! The French translations I've added so far are pulled from the unreleased French translation of Dominion Online (it's in the client source code). My French is nowhere near good enough to translate Dominion cards.
Here are the relevant translations (English followed by French):
- Skulk: Malandrin
- Bandit: Brigand
- Rogue: Bandit
- Boon: Aubaine
- Windfall: Manne
- Hex: Sortilège
Source: https://dominion.games/js/dominion-webclient-body-1.3.4.min.js (look for "FrenchCardNames[" and "FrenchCardTexts[" to find the relevant bits).
I figure it would be better to stick to these mostly official translations where possible. We could update them later if an official published version is released with different names or text. Do you agree?
I agree. I have fixed the French translations for card names for the Empires and Nocturne with the ones from Dominion Online. Here is the result: values-fr.zip
@oboulonis Ok. Your changes were applied with only a few minor edits from me. I can tell there's a few mistakes in the current Dominion Online translation and it isn't quite consistent with the existing Ystari Games translations in some areas (maybe that's why it's not released yet?). Overall, great work on your part!
The only thing I see missing is the short descriptions of the Boon abilities. These are shortened descriptions of the Boon abilities that are shown on the prompts for when you can choose them (e.g. Fool, Pixie, Blessed Village). The full description was too long to show, so brevity is important. I filled in only the short descriptions for The Sea's Gift and The Wind's Gift in French already, since they were easy. The other 10 need to be done. Check the English strings-cards.xml (look for the keys ending in "_shortDesc") for examples of how I did this in English: https://github.com/mehtank/androminion/blob/Nocturne/androminion/res/values/strings-cards.xml#L884
Once we have those in place, we should be ready to post a pre-release.
New Pre-Alpha here (includes German and French translations): https://github.com/mehtank/androminion/releases/tag/v8.05-prealpha5
Please post any issues you find (especially Nocturne ones). Thanks!
Next bit of work involves augmenting the existing AIs to be smart(er) about the Nocturne cards. This is because some of the AIs are only smart enough to work with cards from certain expansions. None of them understand anything about how to use Events or Landmarks either. This won't make them super smart, but may help them perform a bit better, especially Patrick. I'll post here when I have something ready for testing.