androminion icon indicating copy to clipboard operation
androminion copied to clipboard

Informing user when copying a card fails

Open oboulonis opened this issue 8 years ago • 6 comments

Each knight card is unique. As a consequence, playing the Action card Copy from Adventures should not work and androminion should prevent the player to use it on knights. This is not what happens. Androminion allows to use Copy but does nothing. The Copy action is just wasted. To fix this issue, androminion must prevent to select the Knight card pile for Copy.

The issue could concern split card piles as well, when there is only one copy of a kind of card left in the pile (for instance, only 1 sauna and 5 avantos left in the pile).

oboulonis avatar Oct 29 '16 07:10 oboulonis

Actually, it is perfectly valid to call Duplicate (which is the English name of the card), when you can't actually gain the card. Just as any other player choice can be chosen even if it can't be performed in its entirety (see Dominion Second Edition rulebook page 9 or Intrigue 2nd Edition Rulebook page 2). For example, you may call Duplicate when gaining a Mercenary, despite the fact you can't gain the Mercenary after calling (since you can't gain cards not in the Supply unless explicitly instructed to gain a non-Supply card name by name). The only condition for being able to call Duplicate is if the gained card cost 6 coins or less.

However, it should most likely be part of the quick-play logic to never allow calling Duplicate in cases where the Duplicate can't be performed. I can't think of many cases in which you'd want to call Duplicate on something you can't gain (perhaps to get the card off of the Tavern mat so you can trash it to reduce your card count for the purposes of the Wall Landmark?).

dominionator avatar Oct 29 '16 14:10 dominionator

I've added logic that should cause the Quick Play option to not ask to call Duplicate when you can't gain a copy of the card.

dominionator avatar Oct 30 '16 06:10 dominionator

OK. Fair enough. In case players manually activate Duplicate and nothing happens, you should also add something in the log to explicitly inform that the card has no effect: English: Name of the player : Duplicate played. No effect, target card could not be duplicated. French : Name of the player : Copie, carte jouée. Pas d'effet, la carte ciblée n'a pu être copiée. It is more user friendly I think. Impersonalisation is possible.

oboulonis avatar Oct 30 '16 09:10 oboulonis

I like the idea of a log entry when gaining a copy fails. I'll do this for Duplicate and the other copy gainers (Ambassador, Smugglers, Talisman, Mint, Jester, Messenger, Disciple, Pilgrimage). I'm thinking the Log text should be something more like Name: Called Duplicate (this is the standard message for calling a card) Name: Could not gain a copy of Card Name

Could you make a French version of that second message?

dominionator avatar Oct 30 '16 22:10 dominionator

Sure French version Name: N'a pas pu obtenir un exemplaire de Card Name

oboulonis avatar Nov 01 '16 07:11 oboulonis

(perhaps to get the card off of the Tavern mat so you can trash it to reduce your card count for the purposes of the Wall Landmark?). I was also thinking if you wanted to use it as a "trash for benefit" target, like Remodel, Replace, or Expand. But yeah, to me, this is quite a corner case.

ayao44 avatar Aug 18 '17 03:08 ayao44