VisCy icon indicating copy to clipboard operation
VisCy copied to clipboard

Adding support for pyramids

Open edyoshikun opened this issue 1 year ago • 4 comments

This PR adds the support for pyramids to address #125. This modifies the HCSDataloader()

edyoshikun avatar Aug 08 '24 05:08 edyoshikun

@edyoshikun thanks - this implementation seems backward compatible with previous configs for training and prediction for virtual staining and contrastive learning tasks. Can you check with the configs we are sharing with the preprint if they need any change (e.g., explicitly setting the scale = 0)?

mattersoflight avatar Aug 15 '24 21:08 mattersoflight

@mattersoflight we don't need to change the previous configs because by default the Dataloader will be set to "0" the highest resolution if the parameter is not provided in the config.

For the preprint, I thought we were pointing them to viscy=0.2.0, which may or may not have this PR. If we are adding this PR as part of 0.2.0, I'll make the changes.

edyoshikun avatar Aug 15 '24 22:08 edyoshikun

I've tested the basic HCSDataModule with multiple resolution levels, and it's working well. I can load random patches at any resolution level in my pyramid. Thanks @edyoshikun.

@edyoshikun I'm happy to leave this as a branch while we test this out end to end during the course.

talonchandler avatar Aug 17 '24 00:08 talonchandler

The code changes look good, but we should test that training actually works before merging.

ziw-liu avatar Sep 11 '24 16:09 ziw-liu