mylg icon indicating copy to clipboard operation
mylg copied to clipboard

web interface: disable trace

Open jungle-boogie opened this issue 8 years ago • 6 comments

Hi There,

When entering the IP address/host you would like to trace, it's a continuous trace, like mtr. However, there's a slider that when you hover over it, says enable/disable trace. Is the purpose of this to stop a trace after it has started? If so, I'm observing it continuing to ping.

jungle-boogie avatar Nov 15 '16 05:11 jungle-boogie

correct but I couldn't reproduce it w/ chrome (Version 54.0.2840.87 (64-bit)) and safari (Version 10.0.1 (12602.2.14.0.7)) what browser/version you tried?

mehrdadrad avatar Nov 15 '16 16:11 mehrdadrad

I attempted this in firefox 50 or something on Linux. I'll update with the exact version later tonight.

jungle-boogie avatar Nov 15 '16 17:11 jungle-boogie

I can confirm this on Firefox 50.0 and Chrome 54.0.2840.71 on macos. When I put the slider in the off-position it continues to tace.

gummiboll avatar Nov 16 '16 18:11 gummiboll

@gummiboll Thanks! I'll keep this open until it fixed @ Firefox

mehrdadrad avatar Nov 17 '16 06:11 mehrdadrad

A bit busy so can't test/fix myself but I think I found the problem, @mehrdadrad. I believe its this (called from onClickCheck()). I get this stacktrace in firebug:

ReferenceError: notify is not defined

gummiboll avatar Nov 17 '16 19:11 gummiboll

@gummiboll Thanks for investigating I'll try to fix it

mehrdadrad avatar Nov 18 '16 06:11 mehrdadrad