config-rs icon indicating copy to clipboard operation
config-rs copied to clipboard

Published 20 hours ago • verified publisher icon mehcode

Add Dhall support

Open sphw opened this issue 4 years ago • 3 comments

This PR adds Dhall support using serde_dhall, a native Rust implementation of Dhall. Dhall is a functional configuration language designed to make composition of configuration files easier.

closes https://github.com/mehcode/config-rs/issues/123

sphw avatar Jul 30 '21 09:07 sphw

Plus, I messed up the formatting (thank god we have CI for that), here's the patch that fixes it: https://github.com/matthiasbeyer/config-rs/commit/00ed90b908b3fca4cce7c4c2385b5a51df32bef9

You can of course still use the git pull --ff-only line from above, the patch was pushed to this branch and a git rebase --autosquash -i master will squash the fixup away :smile:

Sorry for messing this up...

matthiasbeyer avatar Jul 30 '21 14:07 matthiasbeyer

@matthiasbeyer Thanks for the timely and thorough review

I integrated all your requested changes and comments, and then squashed them into a single commit. I also fixed the error handling case you mentioned above.

Let me know if you have any other comments

sphw avatar Jul 30 '21 23:07 sphw

I have published a PR that should fix the problems during the build. All tests should succeed now.

MGlolenstine avatar Dec 06 '21 13:12 MGlolenstine

@matthiasbeyer it looks like this PR is going stale too? The build PR referenced last in Dec 2021 was merged, and no remaining concerns with this PR for being merged?

polarathene avatar Oct 02 '23 03:10 polarathene

Yep so there's conflicts and this PR needs rebasing.

matthiasbeyer avatar Oct 04 '23 09:10 matthiasbeyer

Yep so there's conflicts and this PR needs rebasing.

Done: #466

@sphw can update their branch here, otherwise my alternative one should be sufficient if they're unresponsive.

polarathene avatar Oct 04 '23 23:10 polarathene

@polarathene I'm closing in favor of your PR, since this has been sitting for almost 2 years now lol. Thanks so much for helping to push it over the finish line.

sphw avatar Oct 05 '23 04:10 sphw