megfile icon indicating copy to clipboard operation
megfile copied to clipboard

s3_buffered_open switch buffered to False (#15)

Open leavers opened this issue 4 years ago • 3 comments

leavers avatar Oct 11 '21 08:10 leavers

测试挂了,还得对应的改一下测试

bbtfr avatar Oct 11 '21 11:10 bbtfr

Codecov Report

Merging #62 (21d0b78) into main (d57aad1) will decrease coverage by 0.34%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   87.43%   87.09%   -0.35%     
==========================================
  Files          33       33              
  Lines        3678     3680       +2     
==========================================
- Hits         3216     3205      -11     
- Misses        462      475      +13     
Impacted Files Coverage Δ
megfile/fs_path.py 100.00% <ø> (ø)
megfile/s3.py 92.22% <ø> (-0.26%) :arrow_down:
megfile/lib/s3_prefetch_reader.py 87.20% <0.00%> (-3.88%) :arrow_down:
megfile/cli.py 0.00% <0.00%> (ø)
megfile/interfaces.py 84.84% <0.00%> (+1.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d57aad1...21d0b78. Read the comment docs.

codecov-commenter avatar Oct 12 '21 05:10 codecov-commenter

代码没问题,但涉及到一些别的库需要的同步更新,暂时不合进去

bbtfr avatar Oct 14 '21 04:10 bbtfr

先关掉了,buffer=False 对读写 pickle 有影响,后面再想办法优化吧

LoveEatCandy avatar Oct 08 '23 06:10 LoveEatCandy