Martin Egri

Results 77 comments of Martin Egri

> O wow, that is a full fledged extension! And you managed to write it in scala JS, that is quite impressive. Thanks, once I got the hang of how...

> > Speaking of integration, how do you want that part to work? From what you've told me so far I think the language server process should just start with...

> > If i understand things correctly the new metals.metalsJavaHome dictates which JDK to run the Language Server with; is this correct? > > Yes, but it needs to be...

> > If JDKManager knows the user has a JDK of version 17+ installed, it (quietly) set metals.metals-java-home to the highest version available; we also update this value if the...

> A lot of VS Code settings can end up in .vscode/settings.json and if you commit it there will be always issue. And also you block users from using any...

> We could have separate file for that setting, which we could commit to the repository instead. I think committing .idea files is not a recommended options overall I'm under...

I was bitten by this today. I'm using Scala and have this model ```scala case class MyRow(id: Int, value: String) case class Changes(before: Option[MyRow], after: MyRow) ``` modelling changes between...