wobble icon indicating copy to clipboard operation
wobble copied to clipboard

continuum normalization may fail for some cases

Open megbedell opened this issue 5 years ago • 3 comments

Currently the sigma clipping in the continuum fitting function is very asymmetric, which @davidwhogg says is "playing with fire." We should check that this doesn't fail for other datasets.

megbedell avatar Jul 20 '18 09:07 megbedell

I agree.

davidwhogg avatar Jul 24 '18 08:07 davidwhogg

ps. We could clip hard and asymmetric, but then do a mean-rms adjustment to compensate for the asymmetry. Put this in as a homework question for me.

davidwhogg avatar Jul 24 '18 08:07 davidwhogg

maybe incorporate continuum fitting into the model itself with a GP and forget about initial normalization??

megbedell avatar Oct 09 '18 15:10 megbedell