Stéphane Peter

Results 94 comments of Stéphane Peter

I did this recently on my fork: https://github.com/megastep/GKAchievementNotification

Interesting idea, however it seems to break a number of our tests at the moment.

Try to run the tests yourself (`make test`), and see which tests fail. These seem to fail even on very common platforms like Ubuntu. Then see what you can change...

FYI, the variable test seems to be the main culprit.

We already have these (except for 7z I guess): ``` --gzip : Compress using gzip (default if detected) --pigz : Compress with pigz --zstd : Compress with zstd --bzip2 :...

It might be a good idea to add a unit test for the cleanup script too.

Believe it or not, early on Makeself was used as part of installers of games from CDROM so this is not exactly a new use case. The easier workaround for...

I understand, but I'm also not clear that this is a decision that can necessarily be made on behalf of the user at the time of the archive's creation. Who's...

While I didn't write this test myself, it appears it is failing because the file disappearing would make the comparison of the permissions before and after extraction fail. Obviously a...

I think this was meant to test that Makeself wouldn't overwrite permissions of any existing files after extraction. So in that sense obliterating the whole directory would break this. If...