Add DisplayVersion to the Installer

[quhxl]

To keep MegaSync up to date with the WinGet Package Manager, the program needs a DisplayVersion in the registry. Could this be added for better UX?

[ItzLevvie]

cc @vtmateos

Could this please be added to the next release of MEGAsync? Right now, Control Panel doesn't display the version for MEGAsync in appwiz.cpl because the DisplayVersion is completely blank and has no version displayed.

WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" "DisplayVersion" "" needs to be changed to WriteRegStr ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}" "DisplayVersion" "${PRODUCT_VERSION}" in https://github.com/meganz/MEGAsync/blob/5e283431091ad45b384c96dbd4d17f00fc883a21/installer_win.nsi#L726

I haven't tested this change, but I don't see any reason why it wouldn't work since PRODUCT_VERSION is declared in https://github.com/meganz/MEGAsync/blob/5e283431091ad45b384c96dbd4d17f00fc883a21/installer_win.nsi#L33

[mattw-mega]

It's not quite that simple, since it would be out of date after the first auto-update. We will keep it in mind, thanks

[msdrigg]

This bug wouldn't be a big deal for me, except this causes winget to update MegaSync on every call to winget upgrade --all (even if the most recent version is already installed). It does this because it doesn't know the currently installed version number, so it defaults to re-installing the latest versoin. This means I re-install MegaSync on every package upgrade.

[chrullrich]

It's not quite that simple, since it would be out of date after the first auto-update. We will keep it in mind, thanks

The only way I can make sense of this statement is if the automatic update puts an updated version into the user profile if the existing installation is all-users and the current user is not an admin. Is that how it works?

An automatic update of a per-user installation has the necessary privileges to update the uninstall subkey in its HKCU, and (if it exists) an automatic update of an all-users installation has these privileges in HKLM, because they are the same as are necessary to update the application files itself.

[Cyber5imon]

As a temporary fix, run this to quickly add the version number into the registry, replacing 4.8.1.0 with the current version number: reg add HKLM\Software\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\MEGAsync /v DisplayVersion /t REG_SZ /d 4.8.1.0