template-string-converter icon indicating copy to clipboard operation
template-string-converter copied to clipboard

autoRemoveTemplateString is not working

Open danulqua opened this issue 2 years ago • 8 comments

The option autoRemoveTemplateString is on, but still it doesn't working. Here is the issue:

CleanShot 2022-11-06 at 10 38 26@2x

Visual Studio Code 1.73.0
Template String Converted v0.6.0

danulqua avatar Nov 06 '22 09:11 danulqua

Bump

AngeloCore avatar Apr 03 '23 18:04 AngeloCore

I have same issue, please fix it soon.

titoworlddev avatar Apr 14 '23 13:04 titoworlddev

feel free to investigate this and create a PR

meganrogge avatar Apr 14 '23 16:04 meganrogge

or @xNocken, who added this feature, could fix it

meganrogge avatar Apr 14 '23 16:04 meganrogge

It has been working fine for me except when there are closing brackets above like I reported in #63. I also had to add some more checks to prevent it from converting back to normal strings when the ${ was not present in the string and the string was edited.

I'm definitely not going to fix this big if else mess that not even the author wants to work on (understandably).

xNocken avatar Apr 14 '23 23:04 xNocken

Yeah this is a tricky one I don't currently have time for

meganrogge avatar Apr 15 '23 00:04 meganrogge

Well, apparently the code looks good, but for some reason it doesn't work. I don't know how vscode extensions work and I can't do tests, to change it and make a PR, but it doesn't seem to be a big bug. It would also be possible to have another extension that causes failures with yours, but I don't think so, because all the other functions work fine. But also now testing again if that option worked and it continues to work badly.

titoworlddev avatar Apr 15 '23 19:04 titoworlddev

回退到0.5.5 是可以正常工作的

maqinghao avatar Jun 21 '24 03:06 maqinghao