easeprobe icon indicating copy to clipboard operation
easeprobe copied to clipboard

feat: support go1.21 build

Open chenrui333 opened this issue 1 year ago • 7 comments
trafficstars

Right now, there is some go.sum discrepancies with go1.21 build, run go mod tidy with go1.21.6 to support go1.21 build.

  • relates to https://github.com/Homebrew/homebrew-core/pull/159493

chenrui333 avatar Jan 10 '24 15:01 chenrui333

this is very similar to kubecm pr, https://github.com/sunny0826/kubecm/pull/847

chenrui333 avatar Jan 10 '24 16:01 chenrui333

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b20cabd) 98.78% compared to head (1efcf1f) 98.88%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   98.78%   98.88%   +0.09%     
==========================================
  Files          85       83       -2     
  Lines        5863     5844      -19     
==========================================
- Hits         5792     5779      -13     
+ Misses         52       48       -4     
+ Partials       19       17       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 11 '24 02:01 codecov-commenter

@chenrui333 there is a failed test here with the following logs:

=== RUN   TestMemcache
    memcache_test.go:48: 
        	Error Trace:	D:/a/easeprobe/easeprobe/probe/client/memcache/memcache_test.go:48
        	Error:      	"dial tcp 127.0.0.1:12345: connectex: No connection could be made because the target machine actively refused it." does not contain "connect timeout"
        	Test:       	TestMemcache
--- FAIL: TestMemcache (0.02s)

please help to check if it's caused by these changes or if the test code needs optimization to align?

samanhappy avatar Jan 11 '24 03:01 samanhappy

@samanhappy I guess we can do a quick rerun to see if it is reproducible, looks like only failed with windows build.

chenrui333 avatar Jan 16 '24 22:01 chenrui333

@chenrui333 it's reproducible and seems to be caused by some low-level implementation in go 1.21 on Windows, you can try to fix it like what I did here.

samanhappy avatar Jan 17 '24 06:01 samanhappy

yeah, let me give a try later, thanks!

chenrui333 avatar Jan 17 '24 16:01 chenrui333

Hi, @chenrui333 could you please fix it? We'd like to update easeprobe to golang 1.21.

suchen-sci avatar Mar 04 '24 09:03 suchen-sci

we are now in go 1.21, so i will close this pr.

suchen-sci avatar Apr 07 '24 02:04 suchen-sci