install.doctor icon indicating copy to clipboard operation
install.doctor copied to clipboard

Dynamic gitlab runner registration

Open enggnr opened this issue 1 year ago • 3 comments
trafficstars

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This change provides the ability to generate Runner auth token for Gitlab runner registration

  • What is the current behavior? (You can also link to an open issue here) Gitlab runner registration token is provided manually. This method is deprecated and will be removed in the future

  • Other information: Fixes #134.

enggnr avatar Dec 29 '23 14:12 enggnr

Image description CodeRabbit


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

github-actions[bot] avatar Dec 29 '23 14:12 github-actions[bot]

Hey @enggnr --- is this ready to be merged? What issue does it address?

ProfessorManhattan avatar Jan 03 '24 23:01 ProfessorManhattan

@ProfessorManhattan, a token was manually added to the secrets to configure Gitlab runner. It was using the now deprecated method of registering runners. This change needs just the Gitlab API token (with right permissions of course) to register a runner at the Group level. It also uses the new method of registering runners.

enggnr avatar Jan 05 '24 10:01 enggnr