install.doctor icon indicating copy to clipboard operation
install.doctor copied to clipboard

Vim/Nvim plugin related fixes

Open enggnr opened this issue 1 year ago • 5 comments
trafficstars

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This fixes issues identified during the setup of Vim/Nvim plugins.

  • Other information: Fixes #123 and #127. Related to #https://github.com/megabyte-labs/AstronVim/pull/1

Summary by CodeRabbit

  • Chore: Removed unused GitSync setup and maintenance code from npm-init.js. This change simplifies the configuration process and reduces potential points of failure, improving maintainability.
  • Refactor: Streamlined the export statement in npm-init.js, removing "main", "scripts", and "version" properties. This change does not affect end-user functionality but enhances code readability and maintainability.

enggnr avatar Dec 27 '23 15:12 enggnr

Image description CodeRabbit

Walkthrough

The changeset primarily focuses on the removal of a GitSync related code block and an export statement from the npm-init.js file. This simplifies the setup process without impacting the core functionality.

Changes

File Path Summary
home/dot_config/npm/config/npm-init.js Removed GitSync related code and an export statement, simplifying the setup process while maintaining core functionality.

🐇

"In the land of code, where logic intertwines, A rabbit hopped and tweaked some lines. GitSync gone, exports no more, Simplicity we do adore! 🎉"


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

github-actions[bot] avatar Dec 27 '23 15:12 github-actions[bot]

Hey @enggnr --- I manually merged the changes so far... I notice that when I run:

bash -ci "nvim --headless -c 'quitall'"

I see:

mason.nvim has not been set up. Make sure to set up 'mason' before 'mason-lspconfig'. :h mason-lspconfig-quickstart`

Also, after the command finishes, when I open nvim it shows a bunch of unstyled notifications that say mason-null-ls and a few names. I wonder, is mason-null-ls an issue? There's something null? Anyway, I'd like to finish the entire boot process of nvim headlessly. It looks like vim is configured properly now but nvim needs some work to headlessly install all the mason languages. Also, can we do anything to improve the start-out experience for nvim? I think for starters, we should have the file tree window open by default, with the initial cursor focus on the text file that's open.

Also, is there a better way of running bash -ci "nvim --headless -c 'quitall'"? i.e. can we do it without an interactive Bash session?

ProfessorManhattan avatar Jan 03 '24 22:01 ProfessorManhattan

mason.nvim has not been set up. Make sure to set up 'mason' before 'mason-lspconfig'. :h mason-lspconfig-quickstart`

It was caused by the presence of .config/npm/config/npm-init.js file. Removing this fixed the problems. I am trying to find what this files is used for.

Note that even though the console says Mason is installing packages if configured, check status with :Mason, after nvim is opened and you use Mason any time, it installs a bunch of items. There is no background way to do it as far as I could tell. Mason does things in the background and this could be why there is no silent install.

enggnr avatar Feb 15 '24 09:02 enggnr

@ProfessorManhattan, this has been addressed. Problem was caused by the file dot_config/npm/config/npm-init.js. I was not able to find what this file does, I've removed that file and dot_config/npm/favourites.yml. If these are needed, we would need to address the failures caused due to these files (mostly the js file).

To show file tree, I've updated the setting in https://github.com/megabyte-labs/AstronVim/commit/2f60dbeaddc9efddeb6202295824dc0b46d7b709.

enggnr avatar Feb 15 '24 12:02 enggnr

Ok good stuff. Thanks

On Thu, Feb 15, 2024, 7:39 AM enggnr @.***> wrote:

@ProfessorManhattan https://github.com/ProfessorManhattan, this has been addressed. Problem was caused by the file dot_config/npm/config/npm-init.js. I was not able to find what this file does, I've removed that file and dot_config/npm/favourites.yml. If these are needed, we would need to address the failures caused due to these files (mostly the js file).

To show file tree, I've updated the setting in megabyte-labs/AstronVim@ 2f60dbe https://github.com/megabyte-labs/AstronVim/commit/2f60dbeaddc9efddeb6202295824dc0b46d7b709 .

— Reply to this email directly, view it on GitHub https://github.com/megabyte-labs/install.doctor/pull/135#issuecomment-1946019176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJRHXIJIHTMBWDGJAQVBQ3YTX6WRAVCNFSM6AAAAABBEPSHACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBWGAYTSMJXGY . You are receiving this because you were mentioned.Message ID: @.***>

ProfessorManhattan avatar Feb 20 '24 21:02 ProfessorManhattan