install.doctor icon indicating copy to clipboard operation
install.doctor copied to clipboard

Published 20 hours ago • verified publisher icon megabyte-labs

SFTPGo configuration

Open enggnr opened this issue 1 year ago • 5 comments
trafficstars

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This change adds features to SFTPGo default configuration - added branding, LDAP integration, etc.

  • What is the current behavior? (You can also link to an open issue here) Default configuration was provided, which has now been enhanced.

  • Other information: Fixes #80.

enggnr avatar Nov 24 '23 13:11 enggnr

Image description CodeRabbit

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

github-actions[bot] avatar Nov 24 '23 13:11 github-actions[bot]

I already manually merged this FYI @enggnr --- still need the documentation on how to acquire the variables though

ProfessorManhattan avatar Dec 23 '23 11:12 ProfessorManhattan

Hi @ProfessorManhattan, I have added the documentation and included the Icon to the branch. These files are needed for the POST script to complete successfully. Please include these files (along with their parent directory) when merging.

enggnr avatar Dec 28 '23 13:12 enggnr

Hey @enggnr --- can you please use the already included logo branding assets located at home/dot_local/etc/branding? Actually, nevermind I just did this. But can you please update the software.yml file to include a script that will install the github: entry? You can leave the github: entry since I might introduce the ability to download from releases. However, for now add something like:

auth-plugin:
  script: |
     curl xyz.com > /usr/local/bin/xyz

Make sure to download the appropriate release if there are multiple platforms etc.

Also, for now, going forward, you can commit directly to master for simple changes to the software.yml or to the docs. However, do please keep me well-informed on what direct commits you're adding.

This might make it easier to debug as well. I don't really follow the traditional git commit / PR model.

ProfessorManhattan avatar Jan 03 '24 23:01 ProfessorManhattan

Added script based installation of auth-plugin https://github.com/megabyte-labs/install.doctor/commit/9b541a0e2a4c54bf8ad0dfcf7e4bdf025db68a80.

enggnr avatar Apr 27 '24 05:04 enggnr