Matt Fellows comments

Results 759 comments of


                                            Matt Fellows

Fix a typo

Sorry, I know that was super picky - but wanted you to get the contribution (and now you know for any future contributions :) )

OneOf property is failing during OAS Schema Validation

According to the docs, mapping is not supported: https://ajv.js.org/json-schema.html#discriminator. It's unclear clear why that's the case. If the author is open to a PR perhaps you could add the feature?

OneOf property is failing during OAS Schema Validation

It looks like somebody has already attempted that: https://github.com/ajv-validator/ajv/pull/2262/files

OneOf property is failing during OAS Schema Validation

I don't think mapping is supported at all.

OneOf property is failing during OAS Schema Validation

I'm not sure what that means, sorry, but to work around it you can _not_ using the mapping. See https://swagger.io/specification/v3/#discriminator-object for how it works without mapping.

OneOf property is failing during OAS Schema Validation

Thanks for your response @epoberezkin! I'm still a little confused as to why we wouldn't want to support this feature. I appreciate it's not currently supported and it's a limitation...

pact_matching, which is MIT licensed, depends on snailquote, which is GPL3

Thanks @grahambinns. Can this be closed now @rholshausen ?

feat(verifier): Added support of set_no_pacts_is_error feature

Looks OK to me @levanoz.

Add Support for Specifying Database Schema via Environment Variable

The database URL can contain the schema you want to deploy it to, e.g. ``` postgres://user:pass@host:5432/dbname ``` Is this not what you need?

Add Support for Specifying Database Schema via Environment Variable

Ah yes, schemas != databases.