janus-gateway icon indicating copy to clipboard operation
janus-gateway copied to clipboard

[1.x] videoroom: support of string_ids/string_ids_user

Open IgorKhomenko opened this issue 9 months ago • 2 comments

This is more a feature request rather than an issue.

There is a case when integrate Janus with 3rd party system where room id is a string, but user id is a number.

With current version of Janus, it's only possible to have ether string or number for both.

It would be very useful to have a way to configure it separately, e.g. to set string_ids = TRUE; and to have a separate variable for users: string_ids_user = FALSE; https://github.com/meetecho/janus-gateway/blob/master/src/plugins/janus_videoroom.c#L1951

I already have a custom branch with this change and wondering is it something you are interested in to have, so I could do a PR.

Thank you in advance

IgorKhomenko avatar Apr 29 '24 06:04 IgorKhomenko

In our case we need change for users string but leave rooms with number. Is it possible in your branch?

amnonbb avatar May 01 '24 09:05 amnonbb

@amnonbb here is a PR https://github.com/meetecho/janus-gateway/pull/3369

IgorKhomenko avatar May 06 '24 13:05 IgorKhomenko