dataflow icon indicating copy to clipboard operation
dataflow copied to clipboard

Allow ports to decline a connection

Open bergie opened this issue 12 years ago • 7 comments

In NoFlo we have situations where a port will not allow a new connection. This means that in Dataflow too we need to be able to decline a connection.

bergie avatar Oct 01 '13 09:10 bergie

What situation?

forresto avatar Oct 01 '13 09:10 forresto

@forresto some examples (note that some of this will change with noflo/noflo#90)

  • Regular port that already has a connection
  • Regular port that already has an IIP
  • Particular ArrayPort index that already has a connection (related to noflo/noflo-ui#14)

Of course the other option would be to always destructively remove whatever was there when dragging a new connection in.

bergie avatar Oct 01 '13 10:10 bergie

Seems better to reject the new.

I see #72 (remove state/iip) is related as well.

forresto avatar Oct 01 '13 10:10 forresto

Another affected issue is #63

bergie avatar Oct 01 '13 10:10 bergie

Should there be some kind of notification system informing the user or do you want to use Dataflow.log(..) for that?

hacfi avatar Oct 01 '13 11:10 hacfi

@hacfi I think the ports that decline connections should simply not be connectable, i.e. no highlight (#63, #37), and dropping on top of them shouldn't establish a connection.

However, we do have a notification mechanism already in Dataflow, for example:

screenshot 2013-10-01 at 13 46 26

bergie avatar Oct 01 '13 11:10 bergie

@bergie I checked out the demos and noticed the highlighting..thanks! I was mainly working with the demo of this repo which doesn’t use highlighting (yet!?).

hacfi avatar Oct 01 '13 13:10 hacfi