fff icon indicating copy to clipboard operation
fff copied to clipboard

Published 20 hours ago • verified publisher icon meekrosoft

Remove consts from defined structs to avoid errors with c++

Open sebirdman opened this issue 4 years ago • 5 comments

This should properly resolve https://github.com/meekrosoft/fff/issues/51

sebirdman avatar Mar 05 '20 02:03 sebirdman

:x: Build fff 85-appveyor failed (commit https://github.com/meekrosoft/fff/commit/b27f8d19ad by @sebirdman)

AppVeyorBot avatar Mar 05 '20 02:03 AppVeyorBot

:x: Build fff 86-appveyor failed (commit https://github.com/meekrosoft/fff/commit/6fb172869f by @sebirdman)

AppVeyorBot avatar Mar 05 '20 02:03 AppVeyorBot

I'm not sure what the tests are doing exactly, i'm not able to reproduce these failures on my machine

sebirdman avatar Mar 05 '20 02:03 sebirdman

The changes introduced by the original pull request require the fff.h to be not included within an extern "C" block when compiling with a cpp compiler.

I fixed the issue by wrapping an additional extern "C++" block around the whole fff.h: https://ci.appveyor.com/project/johwech/fff/builds/32597466

Alternatively it's also possible to just fix the test and tell the users that fff.h cannot be included within an extern "C" segment when a CPP compiler is used: https://ci.appveyor.com/project/johwech/fff/builds/32597324

johwech avatar May 02 '20 05:05 johwech

Hi, first of all thank you for this great tool. This PR allows me to use FFF, how can I help to get it integrated mainstream?

gndl avatar Mar 10 '22 20:03 gndl