txtorcon icon indicating copy to clipboard operation
txtorcon copied to clipboard

possible endpoint-factory API

Open meejah opened this issue 6 years ago • 4 comments

A way to give a completely synchronous Endpoint-returning API for use by "startup"-type code (e.g. before the reactor has been started).

A use-case would be to parse configuration and create endpoints prior to the reactor starting.

meejah avatar Jul 22 '17 21:07 meejah

Coverage Status

Coverage decreased (-1.1%) to 98.844% when pulling ca3ec5c7ba618f11076c55454582ca7bceaef633 on tor-endpoint-manager into 4193b00403487775fbe564312560046d1f5d62ee on master.

coveralls avatar Jul 26 '17 21:07 coveralls

Coverage Status

Coverage decreased (-1.1%) to 98.844% when pulling ca3ec5c7ba618f11076c55454582ca7bceaef633 on tor-endpoint-manager into 4193b00403487775fbe564312560046d1f5d62ee on master.

coveralls avatar Jul 26 '17 21:07 coveralls

Codecov Report

Merging #242 into master will decrease coverage by 1.1%. The diff coverage is 31.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   99.94%   98.84%   -1.11%     
==========================================
  Files          20       20              
  Lines        3662     3721      +59     
==========================================
+ Hits         3660     3678      +18     
- Misses          2       43      +41
Impacted Files Coverage Δ
txtorcon/controller.py 89.56% <31.66%> (-10.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4193b00...ca3ec5c. Read the comment docs.

codecov-io avatar Jul 26 '17 21:07 codecov-io

@warner any opinions? would this have made Foolscap's tor-support easier..?

meejah avatar Jul 26 '18 06:07 meejah