whoisit icon indicating copy to clipboard operation
whoisit copied to clipboard

Are there any plans for type annotations?

Open sanjacob opened this issue 1 year ago • 3 comments

I am willing to help out if necessary, to add type annotations to the whole library. This would really benefit users who use type checkers in their CI pipelines.

Let me know what you think

sanjacob avatar Sep 16 '24 14:09 sanjacob

Sure I'm not opposed to the idea. Do people really type check third party libraries during CI builds? For Python especially that would seem like a nightmare.

meeb avatar Sep 16 '24 15:09 meeb

@meeb mypy benefits from having type annotations for third party libraries, e.g. if I call whoisit.ip(...) inside my own class then mypy will know if whatever I do with the result is valid.

sanjacob avatar Sep 16 '24 15:09 sanjacob

Fair enough that sounds sane.

meeb avatar Sep 16 '24 15:09 meeb