meeb
meeb
Excellent, thanks for the contribution! I'll review this shortly.
It introduced some issues when testing it, so tweaks and retesting mostly.
Sure, go for it. Don't merge the update ffmpeg and update s6 patches though they're now out of date. The main patch (https://github.com/meeb/tubesync/pull/453/commits/a40e3e715e55764085ab3dbe8746a57d79a61f0d) should apply fine still. The issues I...
For some reason you've reset or otherwise lost execute permissions on the init scripts. ```bash $ chmod +x tubesync/config/root/etc/s6-overlay/s6-rc.d/*/run ``` or similar.
The permissions are all set correctly in the Dockerfile other than the `/config` dir which is copied verbatim. You'll really want to preserve the permissions of `/config` as they are...
Thanks for the report, it's entirely possible whatever wasn't working with URLs is working now. I'll given this test again and see if it's OK to merge.
@mikeweyandt I've merged the slightly refactored version of your PR from @FaySmash so I'll close this PR for now. If you want to be on the contributors list feel free...
All TubeSync does is effectively do the API equivalent of passing `--embed-metadata` to `yt-dlp`, it doesn't make any active decisions or attempt to embed any metadata itself. Historically there was...
Make sure you test with outputting the video in an MKV container as well, the default containers for MP4 or WEBM usually have different metadata support.
Interesting, then I would guess either I'm missing something on the API call or the `--embed-metadata` is doing something different to `'addmetadata': True`. I'll take a look later, I've not...