Alexander Medvednikov
Alexander Medvednikov
@spytheman I think it's fine. It's a relatively new feature, and it's comptime, so a pretty specific use case.
Thanks @felipensp Feels a lot more natural.
It only fails on windows, not sure what the issue is ``` Failed command 1: "D:\a\v\v\v.exe" -o "C:\Users\runneradmin\AppData\Local\Temp\v_0\tsession_420_169548300\middleware_test.exe" "D:\a\v\v\vlib\vweb\tests\middleware_test.v" ``` the error is not printed
Great job by the way! This is a great addition.
``` ./vlib/vweb/README.md:308:134: error: must be less than 100 characters Middleware functions will be of type `vweb.Middleware` and are not methods of App, so they could also be imported from other...
You successfully got deep into vweb, good job! :) Perhaps when you have time you could help me out with a similar feature I've been trying to do for a...
just one test failing! ``` Failed command 1: '/home/runner/work/v/v/v' -cflags -fsanitize=address -o '/tmp/v_1001/tsession_7f337d74f740_349323323640/option_nested_struct_test' '/home/runner/work/v/v/vlib/v/tests/option_nested_struct_test.v' ```
Hm I thought `?Node` would imply `?&Node`. @spytheman what do you think?
Ok, makes sense. But I think in the future, it'd be okay to have just ?Node, instead of always requiring ?&Node. Feels a lot more readable and simple.
In V bools are usually named with `is_x` or `show_x` to make it clear they are bools. `startup_message` sounds like a string, it should be `show_startup_message: false` Verbose, but clear.