medusa icon indicating copy to clipboard operation
medusa copied to clipboard

chore(utils): Update internal service update input validation

Open adrien2p opened this issue 1 year ago • 5 comments

What Add more validation to the update input arguments to catch wrong usage

FIXES TRI-64

adrien2p avatar Jul 24 '24 10:07 adrien2p

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 8:25am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 25, 2024 8:25am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:25am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:25am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:25am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:25am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:25am

vercel[bot] avatar Jul 24 '24 10:07 vercel[bot]

⚠️ No Changeset found

Latest commit: 2f5be74bdfc14c14b2d76c3e8d4a7213c117bf3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 24 '24 10:07 changeset-bot[bot]

I am also trying to improve the base API in a separate pr @olivermrbl, though, I ll have to ts expect error in many services because they override the base method with a different API which is not supposed to happen, but I can ignore them for now until the full modules API is settled and in any case those override normalize their input to be consumed by the base methods

adrien2p avatar Jul 24 '24 10:07 adrien2p

@olivermrbl I will stop this pr for now as it is still documented. But it require a much broader work on aligning the different API's the modules are defining VS what the internal service is provided. There is too much discrepancies for now and I d like to finalise my other tasks. wdyt?

thought, I ll keep this pr open for reference in case I get back to this one later

adrien2p avatar Jul 25 '24 08:07 adrien2p

@olivermrbl I will stop this pr for now as it is still documented. But it require a much broader work on aligning the different API's the modules are defining VS what the internal service is provided. There is too much discrepancies for now and I d like to finalise my other tasks. wdyt?

thought, I ll keep this pr open for reference in case I get back to this one later

Yeah, let's do that for now. We can pick it up as part of our polishing phase.

olivermrbl avatar Jul 25 '24 08:07 olivermrbl

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 19 '24 01:09 github-actions[bot]

This PR was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Sep 25 '24 01:09 github-actions[bot]